Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samba3, fusesmb: removing #71323

Merged
merged 1 commit into from Nov 26, 2019
Merged

samba3, fusesmb: removing #71323

merged 1 commit into from Nov 26, 2019

Conversation

d-goldin
Copy link
Contributor

Motivation for this change

Samba 3 has been discontinued since Q1/2015. So I think it's time
to just wipe it from the pkgs. FuseSMB is pretty much abandoned,
upstream does not exist and it's also not as useful as it used to
be anyways.

Let's see if this is controversial.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @aneeshusa as samba 4 maintainer

@d-goldin
samba3, fusesmb: removing
fea7ac4 
Samba 3 has been discontinued since Q1/2015. So I think it's time
to just wipe it from the pkgs. FuseSMB is pretty much abandoned,
upstream does not exist and it's also not as useful as it used to
be anyways.
@jtojnar jtojnar added this to To do in Picking up garbage via automation Oct 18, 2019
@jtojnar jtojnar moved this from To do to In progress in Picking up garbage Oct 18, 2019
Lassulus
Lassulus approved these changes Nov 26, 2019
View reviewed changes
Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not controversial, why do we even ship this? if people want deprecated software let them use old nixpkgs checkouts

@Lassulus Lassulus merged commit 0541d07 into NixOS:master Nov 26, 2019
Picking up garbage automation moved this from In progress to Done Nov 26, 2019
@d-goldin d-goldin deleted the remove_samba3 branch November 26, 2019 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lassulus Lassulus Lassulus approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: clean-up 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
Picking up garbage
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@d-goldin @Lassulus