Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python.pkgs.pip: 19.2.3 -> 19.3.1 #71327

Closed
wants to merge 1 commit into from
Closed

python.pkgs.pip: 19.2.3 -> 19.3.1 #71327

wants to merge 1 commit into from

Conversation

tsusanka
Copy link

@tsusanka tsusanka commented Oct 18, 2019 •
edited

Motivation for this change

Update pipenv to the latest version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @mmahut

I haven't tested this yet, but I'll try to do so asap.

@tsusanka tsusanka requested a review from FRidh as a code owner October 18, 2019 10:37
@FRidh
Copy link
Member

FRidh commented Oct 18, 2019

pip is not pipenv.

Anyway, I'll upgrade pip (again) on staging. Thanks for notifying.

@FRidh FRidh closed this Oct 18, 2019
@tsusanka
Copy link
Author

Apologies, that was a typo, I meant pip of course. Thank you.

@tsusanka tsusanka deleted the tsusanka/update-pip branch October 18, 2019 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tsusanka @FRidh @Janik-Haag