Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wt: Permit overriding of optional libraries #71317

Merged
merged 1 commit into from Oct 20, 2019
Merged

wt: Permit overriding of optional libraries #71317

merged 1 commit into from Oct 20, 2019

Conversation

arthurl
Copy link
Contributor

@arthurl arthurl commented Oct 18, 2019

Motivation for this change

Many of the dependencies in webtoolkit are actually optional (c.f. https://github.com/emweb/wt#dependencies). This change allows the user to opt-out of these optional dependencies by overriding the package with null.

Reason: firebird (one of the optional dependencies) does not build on armv7l. I did not investigate why, because I had no use for it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from WilliButz October 18, 2019 08:57
@WilliButz
Copy link
Member

@GrahamcOfBorg build wt3 wt4

@WilliButz WilliButz merged commit de123f7 into NixOS:master Oct 20, 2019
@arthurl arthurl deleted the arthur/wt-PR branch October 20, 2019 09:39
@arthurl arthurl mentioned this pull request Oct 25, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilliButz WilliButz Awaiting requested review from WilliButz

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arthurl @WilliButz @Janik-Haag