Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zabbix: init at 4.4.0 #71450

Merged
merged 1 commit into from Oct 21, 2019
Merged

zabbix: init at 4.4.0 #71450

merged 1 commit into from Oct 21, 2019

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Oct 20, 2019 •
edited

Motivation for this change

With NixOS 19.09 we offer two LTS versions and 1 regular version of zabbix.

With the 19.09 release of NixOS I set the default version of zabbix to 4.2 which is not a LTS release. I should have selected zabbix 4.0 which is a LTS release. Unfortunately 4.2 is now end of life and users are urged to upgrade to 4.4. See https://www.zabbix.com/life_cycle_and_release_policy for details.

To correct the problem I want to backport zabbix 4.4 to 19.09, though not change the default as users should have explicitly choose to upgrade. Optionally, at the discretion of the release managers @disassembler and @lheckemann I could add some warnings to the zabbix modules instructing users to upgrade to a supported version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @mmahut @PsyanticY

@aanderse
Copy link
Member Author

@GrahamcOfBorg build zabbix44.agent zabbix44.web
@GrahamcOfBorg build zabbix44.proxy-mysql zabbix44.proxy-pgsql zabbix44.proxy-sqlite
@GrahamcOfBorg build zabbix44.server-mysql zabbix44.server-pgsql

jonringer
jonringer approved these changes Oct 20, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds fine on NixOS, not sure how to test:

[10:24:34] jon@jon-desktop /home/jon/projects/nixpkgs ((fdee83d0fb4...))
$ nix-build -A zabbix44
...
/nix/store/rl48np16cqzw0m1hj6snxqnrjqbbf6il-zabbix-agent-4.4.0
/nix/store/bks45cjcfkg0kkgkqfx64r0l979bd7js-zabbix-proxy-4.4.0
/nix/store/1hcwdpnls85v8z0nv952pnjsawk5mnpg-zabbix-proxy-4.4.0
/nix/store/7bizisz86ywv7821zhh2i7gll1r2v20r-zabbix-proxy-4.4.0
/nix/store/var0kaz7i5fs5maychlrph292bgkyr7s-zabbix-server-4.4.0
/nix/store/cam4dbag48ay93inwgq9zhwsiwcf4nnz-zabbix-server-4.4.0
/nix/store/crrq6awjn09skmqf8084px9bwwhapvz8-zabbix-web-4.4.0

@aanderse
Copy link
Member Author

@jonringer currently no test, though @mmahut is working on it.

@aanderse aanderse merged commit 57cf330 into NixOS:master Oct 21, 2019
@aanderse aanderse deleted the zabbix branch October 21, 2019 23:20
@aanderse aanderse mentioned this pull request Oct 21, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aanderse @jonringer