Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

anydesk: add pulseaudio to buildInputs #71449

Merged
merged 1 commit into from Oct 20, 2019
Merged

anydesk: add pulseaudio to buildInputs #71449

merged 1 commit into from Oct 20, 2019

Conversation

mweinelt
Copy link
Member

Motivation for this change

Audio support requires libpulse.so and the application complained
about not being able to find it.

2019-10-20-180053_1200x800_scrot

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @shyim

@mweinelt
anydesk: add pulseaudio to buildInputs
deee216 
Audio support requires libpulse.so and the application complained
about not being able to find it.
@flokli
Copy link
Contributor

flokli commented Oct 20, 2019

@mweinelt can you change this to use autopatchelfHook, and add pulseaudio to autoPatchelfLibs?

@flokli
Copy link
Contributor

flokli commented Oct 20, 2019

Ah, adding pulseaudio to autoPatchelfLibs won't work - autoPatchelfHook still won't know it needs to add it to RPATH. nvm, LGTM.

@flokli flokli merged commit 64dce73 into NixOS:master Oct 20, 2019
@mweinelt mweinelt deleted the pr/anydesk/libpulse.so branch October 20, 2019 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shyim shyim shyim approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mweinelt @flokli @shyim