Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matrix-synapse: 1.4.0 -> 1.4.1 #71360

Merged
merged 1 commit into from Oct 25, 2019
Merged

matrix-synapse: 1.4.0 -> 1.4.1 #71360

merged 1 commit into from Oct 25, 2019

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Oct 18, 2019

Motivation for this change

https://github.com/matrix-org/synapse/releases/tag/v1.4.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @pacien @Vskilet @Ekleog

@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Oct 18, 2019
@ofborg ofborg bot requested review from pacien, Ekleog and Ralith October 18, 2019 20:25
@pacien
Copy link
Contributor

pacien commented Oct 18, 2019

@ofborg test matrix-synapse

@pacien
Copy link
Contributor

pacien commented Oct 18, 2019

Unit tests seem to fail on Darwin. It doesn't seem new though.
Perhaps should this platform be blacklisted for this package?

@risicle
Copy link
Contributor

risicle commented Oct 20, 2019

I can confirm failure on macos 10.13:

tests.test_visibility.FilterEventsForServerTestCase.test_large_room
===============================================================================
[FAIL]
Traceback (most recent call last):
  File "/private/tmp/nix-build-matrix-synapse-1.4.1.drv-0/matrix-synapse-1.4.1/tests/rest/media/v1/test_url_preview.py", line 247, in test_non_ascii_preview_content_type
    self.assertEqual(channel.code, 200)
  File "/nix/store/k66dzav0xyij9wjw01f2996dyhrp5kkn-python3.7-Twisted-18.9.0/lib/python3.7/site-packages/twisted/trial/_synctest.py", line 432, in assertEqual
    super(_Assertions, self).assertEqual(first, second, msg)
  File "/nix/store/gaascisqfmxckzhvs5q1wbx6ycsbk4fi-python3-3.7.4/lib/python3.7/unittest/case.py", line 852, in assertEqual
    assertion_func(first, second, msg=msg)
  File "/nix/store/gaascisqfmxckzhvs5q1wbx6ycsbk4fi-python3-3.7.4/lib/python3.7/unittest/case.py", line 845, in _baseAssertEqual
    raise self.failureException(msg)
twisted.trial.unittest.FailTest: 500 != 200

tests.rest.media.v1.test_url_preview.URLPreviewTests.test_non_ascii_preview_content_type
===============================================================================
[FAIL]
Traceback (most recent call last):
  File "/private/tmp/nix-build-matrix-synapse-1.4.1.drv-0/matrix-synapse-1.4.1/tests/rest/media/v1/test_url_preview.py", line 214, in test_non_ascii_preview_httpequiv
    self.assertEqual(channel.code, 200)
  File "/nix/store/k66dzav0xyij9wjw01f2996dyhrp5kkn-python3.7-Twisted-18.9.0/lib/python3.7/site-packages/twisted/trial/_synctest.py", line 432, in assertEqual
    super(_Assertions, self).assertEqual(first, second, msg)
  File "/nix/store/gaascisqfmxckzhvs5q1wbx6ycsbk4fi-python3-3.7.4/lib/python3.7/unittest/case.py", line 852, in assertEqual
    assertion_func(first, second, msg=msg)
  File "/nix/store/gaascisqfmxckzhvs5q1wbx6ycsbk4fi-python3-3.7.4/lib/python3.7/unittest/case.py", line 845, in _baseAssertEqual
    raise self.failureException(msg)
twisted.trial.unittest.FailTest: 500 != 200

tests.rest.media.v1.test_url_preview.URLPreviewTests.test_non_ascii_preview_httpequiv
-------------------------------------------------------------------------------

@aanderse
Copy link
Member

Given the failing tests are not new to this PR is anyone against merging?

@Ma27
Copy link
Member Author

Ma27 commented Oct 25, 2019

I'd probably disable tests on darwin or even the platform support though. Apart from that, I'm using matrix-synapse 1.4.1 for some time now, so this should be good to go.

@aanderse
Copy link
Member

@Ma27 sounds good. After disabling tests as you described we should definitely merge then. 👍

@Ma27
Copy link
Member Author

Ma27 commented Oct 25, 2019

Done.

@ofborg build matrix-synapse

@Ekleog
Copy link
Member

Ekleog commented Oct 25, 2019

@ofborg build nixosTests.matrix-synapse

@Ekleog
Copy link
Member

Ekleog commented Oct 25, 2019

Thanks!

@Ekleog Ekleog merged commit b262fef into NixOS:master Oct 25, 2019
@Ma27 Ma27 deleted the bump-matrix-synapse branch October 25, 2019 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacien pacien Awaiting requested review from pacien

@Ekleog Ekleog Awaiting requested review from Ekleog

@Ralith Ralith Awaiting requested review from Ralith

Assignees
No one assigned
Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Ma27 @pacien @risicle @aanderse @Ekleog