Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

betaflight-configurator: 10.5.1 -> 10.6.0 #71073

Merged
merged 1 commit into from Oct 20, 2019
Merged

betaflight-configurator: 10.5.1 -> 10.6.0 #71073

merged 1 commit into from Oct 20, 2019

Conversation

nyanloutre
Copy link
Member

Motivation for this change

Also fix icon

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @wucke13

@wucke13
Copy link
Contributor

wucke13 commented Oct 13, 2019

Builds fine and binary runs. Haven't checked actual usage yet, but I do not expect issues there. Thank you for the contribution @nyanloutre !

@ofborg ofborg bot requested a review from wucke13 October 13, 2019 10:19
@nyanloutre
Copy link
Member Author

I modified some config and flashed an new firmware without issue

@c0bw3b c0bw3b merged commit 410d794 into NixOS:master Oct 20, 2019
@nyanloutre nyanloutre deleted the betaflight_configurator_10_6_0 branch October 20, 2019 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wucke13 wucke13 wucke13 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nyanloutre @wucke13 @c0bw3b