Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exercism module no proxy #71391

Merged
merged 3 commits into from Oct 20, 2019
Merged

Exercism module no proxy #71391

merged 3 commits into from Oct 20, 2019

Conversation

NobbZ
Copy link
Contributor

@NobbZ NobbZ commented Oct 19, 2019

Motivation for this change

Somewhere inbetween 3.0.11 and 3.0.12 the exercism team changed from a thirdparty dependency manager to go modules.

This PR reflects this change.

Please be aware of the fact, that this PR is based on #71049 and should not get merged before that. Though without it beeing merged, build will fail eventually because of the reasons explained in the other PR.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions (Arch Linux)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @rbasso

@ofborg ofborg bot requested a review from kalbasit October 19, 2019 17:22
@marsam
Copy link
Contributor

marsam commented Oct 20, 2019

sorry for the delay, I've merged #71049. Would you mind rebasing onto master?

@NobbZ
Copy link
Contributor Author

NobbZ commented Oct 20, 2019

Rebased and force pushed.

@ofborg ofborg bot removed the 6.topic: golang label Oct 20, 2019
@marsam marsam merged commit b9d37f0 into NixOS:master Oct 20, 2019
@marsam
Copy link
Contributor

marsam commented Oct 20, 2019

Thank you!

peti pushed a commit that referenced this pull request Oct 21, 2019
@NobbZ @peti
exercism: buildGoPackage -> buildGoModule (#71391)
ff21324
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jan 27, 2020
@NobbZ @dtzWill
exercism: buildGoPackage -> buildGoModule (NixOS#71391)
947dd87 
(cherry picked from commit b9d37f0)
@NobbZ NobbZ deleted the exercism-module-no-proxy branch November 22, 2021 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NobbZ @marsam