Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/make-iso9660-image: Fix storeContents documentation #71355

Merged
merged 2 commits into from
Oct 18, 2019
Merged

nixos/make-iso9660-image: Fix storeContents documentation #71355

merged 2 commits into from
Oct 18, 2019
+3 −3

Conversation

chkno
Copy link
Member

@chkno chkno commented Oct 18, 2019 •
edited
Loading

packages was renamed to storeContents in
668c146, but this comment
describing its purpose was not updated to match.

chkno added 2 commits October 18, 2019 11:58
@chkno
nixos/make-iso9660-image: Fix storeContents documentation
4623f0a 
`packages` was renamed to `storeContents` in
668c146, but this comment
describing its purpose was not updated to match.
@chkno
nixos/make-iso9660-image: Fix doc typo
ac65940
@chkno chkno force-pushed the fix-storeContents-doc branch from 836ff01 to ac65940 Compare October 18, 2019 18:59
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 18, 2019
worldofpeace
worldofpeace approved these changes Oct 18, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find, this is deep git history here 😄

@worldofpeace worldofpeace merged commit 676a988 into NixOS:master Oct 18, 2019
@chkno chkno deleted the fix-storeContents-doc branch November 4, 2019 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chkno @worldofpeace