Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arrayfire: add #71413

Merged
merged 1 commit into from Oct 20, 2019
Merged

arrayfire: add #71413

merged 1 commit into from Oct 20, 2019

Conversation

chessai
Copy link
Member

@chessai chessai commented Oct 20, 2019 •
edited

Motivation for this change

Add the missing arrayfire library to nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

@chessai
Copy link
Member Author

chessai commented Oct 20, 2019

Not tested on MacOS or other linux distributions.

No nixos tests available for this package.

No packages in nixpkgs depend on the previously-unavailable arrayfire nixpkg, so no packages should be affected.

There are no binary files, but @dmjio has confirmed that he can link against this in his haskell bindings and run the code.

There can be no change to the closure size of a new package.

All documentation is new.

@chessai
Copy link
Member Author

chessai commented Oct 20, 2019

not sure why the first CI failure occurred. i just ran

nix-build -A arrayfire --arg config '{ allowUnfree = true; }' --arg overlays '[]' and it found pkgs.mesa_noglu just fine.

@chessai
Copy link
Member Author

chessai commented Oct 20, 2019

ok, disabled the alias. wasn't aware of that.

@chessai chessai changed the title Add arrayfire arrayfire: add Oct 20, 2019
@chessai
Copy link
Member Author

chessai commented Oct 20, 2019

added support for darwin. @dmjio has confirmed that this works for him, with the caveat that you cant get cudatoolkit so arrayfire will offload to cpu.

@cleverca22 cleverca22 merged commit b03da42 into NixOS:master Oct 20, 2019
@chessai
Copy link
Member Author

chessai commented Oct 20, 2019

thanks!

@dmjio
Copy link
Member

dmjio commented Oct 20, 2019

Thanks @cleverca22 @chessai

@chessai chessai mentioned this pull request Oct 20, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cleverca22 cleverca22 cleverca22 approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chessai @dmjio @cleverca22