Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: c7e1fde9dc0f
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: e18646b7e3db
Choose a head ref
  • 2 commits
  • 1 file changed
  • 1 contributor

Commits on Oct 12, 2019

  1. buildGoModule: remove cached lookup results and tiles 

    Since GO 1.13, the go command caches the lookup results and tiles in
$GOPATH[1], hence making the module directory non-deterministic.

Use the `-f` flag when removing /sumdb, for compatibility with Go 1.12
because in that version does not exists that directory.

[1] https://go.googlesource.com/proposal/+/master/design/25530-sumdb.md#command-client
    @marsam
    marsam committed Oct 12, 2019
    Copy the full SHA
    589d4ff View commit details

Commits on Oct 20, 2019

  1. Merge pull request #71049 from marsam/buildGoModule-disable-goproxy 

    buildGoModule: disable default go module proxy
    @marsam
    marsam authored Oct 20, 2019
    Copy the full SHA
    e18646b View commit details
Showing with 2 additions and 0 deletions.
  1. +2 −0 pkgs/development/go-modules/generic/default.nix
2 changes: 2 additions & 0 deletions pkgs/development/go-modules/generic/default.nix
View file
Original file line number Diff line number Diff line change
@@ -73,6 +73,8 @@ let
installPhase = args.modInstallPhase or ''
runHook preInstall
# remove cached lookup results and tiles
rm -rf "''${GOPATH}/pkg/mod/cache/download/sumdb"
cp -r "''${GOPATH}/pkg/mod/cache/download" $out
runHook postInstall