Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pypi2nix: add missing setuptools dependency #71336

Merged
merged 1 commit into from Oct 18, 2019
Merged

pypi2nix: add missing setuptools dependency #71336

merged 1 commit into from Oct 18, 2019

Conversation

edef1c
Copy link
Member

@edef1c edef1c commented Oct 18, 2019

Motivation for this change

pypi2nix was broken by f7e28bf, which removed
setuptools from the default propagatedBuildInputs of Python packages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@edef1c
pypi2nix: add missing setuptools dependency
23fd70d 
Broken by f7e28bf, which removed
setuptools from the default propagatedBuildInputs of Python packages.
@edef1c edef1c added the 9.needs: port to stable A PR needs a backport to the stable release. label Oct 18, 2019
@worldofpeace worldofpeace merged commit 81acba5 into NixOS:master Oct 18, 2019
@edef1c edef1c deleted the pypi2nix-setuptools branch October 19, 2019 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@edef1c @worldofpeace