Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/nix-daemon: don't refer to deprecated option aliases #71338

Merged
merged 1 commit into from Oct 21, 2019
Merged

nixos/nix-daemon: don't refer to deprecated option aliases #71338

merged 1 commit into from Oct 21, 2019

Conversation

edef1c
Copy link
Member

@edef1c edef1c commented Oct 18, 2019

Motivation for this change

The gc- prefixed versions of these options have been deprecated since Nix 2.0.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @grahamc

@edef1c
nixos/nix-daemon: don't refer to deprecated option aliases
a68219b 
The `gc-` prefixed versions of these options have been
deprecated since Nix 2.0.
worldofpeace
worldofpeace approved these changes Oct 18, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example is fine
Screenshot from 2019-10-18 17-08-55

Though what implications does this have on users upgrading nix versions?
(when was gc-keep-outputs == keep-outputs a compatible config?)

@edef1c
Copy link
Member Author

edef1c commented Oct 19, 2019

The options have been equivalent, with the gc- versions deprecated, since Nix 2.0. I'm not sure for how long we should be counting on NixOS systems running Nix 1.x.

@worldofpeace
Copy link
Contributor

Hmm, I recall commits from @edolstra not really caring about Nix 1.x anymore so let's go for it.

@edef1c edef1c merged commit 0599c89 into NixOS:master Oct 21, 2019
@edef1c edef1c deleted the nix-daemon-opt-aliases branch October 21, 2019 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@edef1c @worldofpeace