Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pgsanity: add missing postgresql checkInput #71340

Merged
merged 2 commits into from Oct 18, 2019
Merged

pythonPackages.pgsanity: add missing postgresql checkInput #71340

merged 2 commits into from Oct 18, 2019

Conversation

edef1c
Copy link
Member

@edef1c edef1c commented Oct 18, 2019

Motivation for this change

Without this, the package doesn't build because all the tests fail.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@edef1c edef1c requested a review from FRidh as a code owner October 18, 2019 12:35
@jonringer
Copy link
Contributor

can you remove the meta.broken = true; :)

@worldofpeace worldofpeace merged commit 0e834b1 into NixOS:master Oct 18, 2019
@worldofpeace
Copy link
Contributor

backported in e5cc98f 7cb8176

@edef1c edef1c deleted the pgsanity-deps branch October 18, 2019 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nalbyuites nalbyuites Awaiting requested review from nalbyuites

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@edef1c @jonringer @worldofpeace