Fix/clean up various ibus-engines #71442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtojnar
force-pushed
the
ibus-fixes
branch
2 times, most recently
from
63b0cdc
to
4847d8a
Compare
|
Are these changes relevant to any other IBus input methods? |
|
Yes, all input methods should be checked and updated. I already did this in typing booster and some other in the past. Need to run now, will try to continue during the week. (Or anyone can feel free to push here.) Also did not test this other than by running the setup execs on non-ibus system. |
10 tasks
Closed
|
The installed tests seem to be failing at the moment: I will need to check if adding |
jtojnar
force-pushed
the
ibus-fixes
branch
2 times, most recently
from
91d1b1f
to
36b7a64
Compare
|
Apparently, fujiwarat/ibus-anthy@5a9e485 is not yet merged to a stable release, so no tests for ibus-anthy. Managed to get |
ofborg
bot
added
6.topic: GNOME
|
I manually tested all the engines and they seem to work except for uniemoji and hangul. Hopefully, the latest push fixes uniemoji (edit: it does) but hangul does not seem to print any errors so more debugging will be required. Also we should try to write some tests. |
|
The merging of the attrsets in f581284 is ugly but until we have NixOS/rfcs#58, there is not much room for improvement. |
worldofpeace
suggested changes
Dec 6, 2019
There was a problem hiding this comment.
Thanks, any test case would help with keeping up on these packages 👍
I went commit by commit, here's what I noticed.
-
ibus-engines.libpinyin: 1.10.0 -> 1.11.1
Commit message needs indent fix. -
ibus-engines.anthy: clean up
I believe we should be using fetchFromGitHub for the fetch.
The commit msg has* 1.5.11 switched from intltool to anthy. probably meant gettext? -
ibus-engines.uniemoji: modernize
Let's use placeholder -
nixos/ibus: install D-Bus services
Not sure if I'm remembering this correctly, but could we get issues with multiple uses of
programs.dconf.enablein our modules?
👍 Yeah this RFC would make lots of code feel better. |
* We are using python3.withPackages, which will be used via shebang. - gobject-introspection is used for setup hook
* format the expression and reorder to canonical order * gobject-introspection is used for setup hooks so it should be in native inputs * wrapPython is not necessary * 1.5.11 switched from intltool to gettext
* https://github.com/libhangul/ibus-hangul/releases/tag/1.5.2 * https://github.com/libhangul/ibus-hangul/releases/tag/1.5.3 * switch to gettext (libhangul/ibus-hangul@8745e3f) * drop wrapPython, patch shebangs hook will take care of that
* add setup again * patch shebangs instead of wrapping * format the expression
The nested list is intentional as it highlights important changes in each release. There are not many, though.
I keep confusing it too but
Oops, fixed.
👍
It should not matter unless someone sets it to something different than |
* Rely on patchShebangsHook instead of wrapPython * Format the expression
IBus contains some D-Bus services, we should install them too. And enable dconf properly.
For example, extra meta tags.
worldofpeace
approved these changes
Dec 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #68837