Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: add package set for graalpython 3.7 #71441

Merged
merged 1 commit into from Oct 22, 2019
Merged

Python: add package set for graalpython 3.7 #71441

merged 1 commit into from Oct 22, 2019

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Oct 20, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@FRidh
Copy link
Member Author

FRidh commented Oct 20, 2019 •
edited

Setuptools can't actually build yet. Maybe #71438 helps? According to upstream graalpython likely won't work with packages but let's see.

To do:

  • setup hook for $PYTHONPATH. Don't want to add it to the interpreter because that would cause a rebuild. Hmm...
  • sitecustomize.py needs to be copied in. That means we need to do a build anyway.

@FRidh FRidh force-pushed the graal branch 2 times, most recently from 8512411 to fd044d7 Compare October 20, 2019 14:10
@FRidh
pythonInterpreters.graalpython37: init
b4a9295 
Add an interpreter with package set for graalpython 3.7.
@FRidh FRidh changed the base branch from master to staging October 20, 2019 17:56
@FRidh FRidh merged commit 43bbece into NixOS:staging Oct 22, 2019
@FRidh FRidh deleted the graal branch October 22, 2019 07:16
@FRidh
Copy link
Member Author

FRidh commented Oct 22, 2019

@volth while this was not ready yet I decided to get it in so it can incrementally be improved. In my previous comment I mentioned two items that need to be added to the derivation.

If I am correct a graal build does not take much time, it just takes a lot of memory. What do you suggest, perform a new build specifically for graalpython, or add these two items always? Note the setup hook can be undesirable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: work-in-progress 6.topic: python 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@FRidh