Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: add package set for graalpython 3.7 #71441

Merged
merged 1 commit into from
Oct 22, 2019
Merged

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Oct 20, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

@FRidh FRidh added the 2.status: work-in-progress This PR isn't done label Oct 20, 2019
@FRidh
Copy link
Member Author

FRidh commented Oct 20, 2019

Setuptools can't actually build yet. Maybe #71438 helps? According to upstream graalpython likely won't work with packages but let's see.

To do:

  • setup hook for $PYTHONPATH. Don't want to add it to the interpreter because that would cause a rebuild. Hmm...
  • sitecustomize.py needs to be copied in. That means we need to do a build anyway.

Sorry, something went wrong.

@FRidh FRidh force-pushed the graal branch 2 times, most recently from 8512411 to fd044d7 Compare October 20, 2019 14:10
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-linux: 1-10 labels Oct 20, 2019
Add an interpreter with package set for graalpython 3.7.
@FRidh FRidh changed the base branch from master to staging October 20, 2019 17:56
@ofborg ofborg bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: golang 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: qt/kde 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild 10.rebuild-linux-stdenv This PR causes stdenv to rebuild labels Oct 20, 2019
@ofborg ofborg bot added 8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: golang 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: qt/kde 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild 10.rebuild-linux-stdenv This PR causes stdenv to rebuild 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ labels Oct 20, 2019
@FRidh FRidh merged commit 43bbece into NixOS:staging Oct 22, 2019
@FRidh FRidh deleted the graal branch October 22, 2019 07:16
@FRidh
Copy link
Member Author

FRidh commented Oct 22, 2019

@volth while this was not ready yet I decided to get it in so it can incrementally be improved. In my previous comment I mentioned two items that need to be added to the derivation.

If I am correct a graal build does not take much time, it just takes a lot of memory. What do you suggest, perform a new build specifically for graalpython, or add these two items always? Note the setup hook can be undesirable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: work-in-progress This PR isn't done 6.topic: python 8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant