Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "nixos/gnome3: fix gnome-flashback" #71410

Merged
merged 1 commit into from Oct 20, 2019
Merged

Revert "nixos/gnome3: fix gnome-flashback" #71410

merged 1 commit into from Oct 20, 2019

Conversation

worldofpeace
Copy link
Contributor

This reverts commit 60aedad.

Using tests from #71212 I am now unable to reproduce there being issues
with starting the default metacity flashback session without this.

Motivation for this change

cc @jtojnar, while trying custom sessions with #71212 is definetly still weird, I can see in the logs it falling back to non-systemd startup anyway.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@worldofpeace
Revert "nixos/gnome3: fix gnome-flashback"
42f567b 
This reverts commit 60aedad.

Using tests from NixOS#71212 I am now unable to reproduce there being issues
with starting the default metacity flashback session without this.
@worldofpeace worldofpeace merged commit 730a6f2 into NixOS:master Oct 20, 2019
@worldofpeace worldofpeace deleted the revert-thing branch October 20, 2019 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@worldofpeace