Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

luksroot: yubikey fixes #71412

Closed
wants to merge 3 commits into from
Closed

luksroot: yubikey fixes #71412

wants to merge 3 commits into from
+142 −48

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Oct 20, 2019

Turns out the 9570 doesn't have a NFC adapter like I thought, but in case anyone ever wants to extend support for it.

Motivation for this change

cryptsetup behaved pretty weird last two days failing for random reasons.
Tested with Yubikey 5.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package labels Oct 20, 2019
@ofborg ofborg bot requested a review from offlinehacker October 20, 2019 01:12
@eadwu eadwu marked this pull request as ready for review October 20, 2019 01:24
@eadwu eadwu force-pushed the luksroot/yubikey-fixes branch 3 times, most recently from bbca388 to 369214e Compare October 23, 2019 22:18
@eadwu eadwu force-pushed the luksroot/yubikey-fixes branch from 369214e to adb1435 Compare October 24, 2019 01:22
@eadwu eadwu force-pushed the luksroot/yubikey-fixes branch from adb1435 to 4e5076d Compare October 25, 2019 01:51
@eadwu eadwu closed this Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lassulus Lassulus

@offlinehacker offlinehacker

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eadwu @Lassulus