Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emacsPackages.vterm: fix dynamic library and autoloaders #71347

Merged
merged 1 commit into from Oct 28, 2019

Conversation

peterhoeg
Copy link
Member

Motivation for this change

We need both the .so as well as the proper autoloaders that are generated when
we build an emacs package, so we cannot use the normal stdenv.mkDerivation but
have to inject the building of the libraries instead.

Also, use the proper libvterm-neovim we have in nixpkgs instead of vendoring it.

Without this, spacemacs doesn't detect the package as installed and instead tries to install it itself. I haven't tried with vanilla emacs but without the vterm-pkg.el and auto loader, I don't think it will work.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @lovek323 @peti @the-kenny @jwiegley

We need both the .so as well as the proper autoloaders that are generated when
we build an emacs package, so we cannot use the normal stdenv.mkDerivation but
have to inject the building of the libraries instead.

Also, use the proper libvterm-neovim we have in nixpkgs instead of vendoring it.
@peterhoeg peterhoeg merged commit c833fb3 into NixOS:master Oct 28, 2019
@peterhoeg peterhoeg deleted the f/emacs_vterm branch October 28, 2019 04:23
@peterhoeg peterhoeg restored the f/emacs_vterm branch October 29, 2019 00:22
@peterhoeg peterhoeg deleted the f/emacs_vterm branch October 31, 2019 04:29
@Atemu
Copy link
Member

Atemu commented May 1, 2020

If anyone else comes across this PR with the same issue I just had, you need to purge .emacs.d/elpa/$ver/$branch/vterm-* or else Spacemacs will still try to use its local vterm despite this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants