Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gtk3: Enable separated debug info on Linux #71426

Merged
merged 1 commit into from Oct 21, 2019
Merged

gtk3: Enable separated debug info on Linux #71426

merged 1 commit into from Oct 21, 2019

Conversation

artemist
Copy link
Member

@artemist artemist commented Oct 20, 2019 •
edited

When debugging gtk3 errors or errors in applications that use gtk, it
can be useful to have full debuginfo. This adds debug information in a
separate output so it will not bloat normal systems.

Motivation for this change

I found an error in gtk3 which I was attempting to debug. I normally set environment.enableDebugInfo = true in my NixOS config, but gtk does not have debug info. This adds separated debug info so that I can debug such applications.

Things done
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @7c6f434c @vcunat @lethalman

@artemist
gtk3: Enable separated debug info on Linux
0a8ac3b 
When debugging gtk3 errors or errors in applications that use gtk, it
can be useful to have full debuginfo. This adds debug information in a
separate output so it will not bloat normal systems.
@ofborg ofborg bot requested review from 7c6f434c and vcunat October 20, 2019 06:12
hedning
hedning approved these changes Oct 20, 2019
View reviewed changes
Copy link
Contributor

@hedning hedning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 gtk is absolutely a major library which should have this enabled (#18530)

worldofpeace
worldofpeace approved these changes Oct 21, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do glib too?

@7c6f434c 7c6f434c merged commit edb5c34 into NixOS:staging Oct 21, 2019
@jtojnar
Copy link
Contributor

jtojnar commented Oct 26, 2019

Weird, I thought we already had this enabled for glib.

@jtojnar jtojnar mentioned this pull request Oct 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedning hedning hedning approved these changes

@worldofpeace worldofpeace worldofpeace approved these changes

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@vcunat vcunat Awaiting requested review from vcunat

Assignees
No one assigned
Labels
10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@artemist @jtojnar @hedning @worldofpeace @7c6f434c