Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.clash-{ghc,lib,prelude}: mark unbroken #71332

Merged
merged 1 commit into from Oct 18, 2019
Merged

haskellPackages.clash-{ghc,lib,prelude}: mark unbroken #71332

merged 1 commit into from Oct 18, 2019

Conversation

emilazy
Copy link
Member

@emilazy emilazy commented Oct 18, 2019

Motivation for this change

These build and work fine as of 1.0.0. Split off from #71238 per @cdepillabout.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@emilazy emilazy mentioned this pull request Oct 18, 2019
Merged
10 tasks
@cdepillabout
Copy link
Member

@emilazy Thanks for splitting off this PR.

@peti I've confirmed these three packages compile correctly. This should be ready to be merged.

@peti peti merged this pull request into NixOS:haskell-updates Oct 18, 2019
@emilazy emilazy deleted the fix-clash branch October 18, 2019 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@emilazy @cdepillabout @peti