Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rrsync: Make perl a run-time dependency #71344

Merged
merged 1 commit into from Oct 19, 2019
Merged

rrsync: Make perl a run-time dependency #71344

merged 1 commit into from Oct 19, 2019

Conversation

ryanfitzsimon
Copy link
Contributor

@ryanfitzsimon ryanfitzsimon commented Oct 18, 2019 •
edited

perl is a run-time dependency, so it should be in buildInputs rather
than nativeBuildInputs.

This has been preventing patchShebangsAuto() in fixupOutputHooks from
patching the /usr/bin/perl interpreter shebang in $out/bin/rrsync since
61bc03c.

Resolves #71198

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @andir @vcunat @kampfschlaefer

@ryanfitzsimon
rrsync: Make perl a run-time dependency
6142b68 
perl is a run-time dependency, so it should be in buildInputs rather
than nativeBuildInputs.

This has been preventing patchShebangsAuto() in fixupOutputHooks from
patching the /usr/bin/perl interpreter shebang in $out/bin/rrsync since
61bc03c.

Resolves NixOS#71198
@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 19, 2019

@GrahamcOfBorg build rrsync

c0bw3b
c0bw3b approved these changes Oct 19, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nix-review pr 71344 1

1 package were build:
  • rrsync
$ head -n 1 results/rrsync/bin/rrsync 
#!/nix/store/939gkqx4mbpf5df0s4vx57ii3n79ppm9-perl-5.30.0/bin/perl

@c0bw3b c0bw3b merged commit f203d50 into NixOS:master Oct 19, 2019
c0bw3b pushed a commit that referenced this pull request Oct 19, 2019
@ryanfitzsimon @c0bw3b
rrsync: Make perl a run-time dependency (#71344)
2af038e 
perl is a run-time dependency, so it should be in buildInputs rather
than nativeBuildInputs.

This has been preventing patchShebangsAuto() in fixupOutputHooks from
patching the /usr/bin/perl interpreter shebang in $out/bin/rrsync since
61bc03c.

Resolves #71198

(cherry picked from commit f203d50)
peti pushed a commit that referenced this pull request Oct 21, 2019
@ryanfitzsimon @peti
rrsync: Make perl a run-time dependency (#71344)
9ab798a 
perl is a run-time dependency, so it should be in buildInputs rather
than nativeBuildInputs.

This has been preventing patchShebangsAuto() in fixupOutputHooks from
patching the /usr/bin/perl interpreter shebang in $out/bin/rrsync since
61bc03c.

Resolves #71198
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@multun multun multun approved these changes

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rrsync doesn't hardcode perl's path
3 participants
@ryanfitzsimon @c0bw3b @multun