Python: setuptools/wheel/pip now bootstrap from source #71438
Merged
+79
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
FRidh
force-pushed
the
bootstrap
branch
2 times, most recently
from
e149802 to
8a72a33
Compare
Since wheel support was introduced in 2015 we always relied on pre-built wheels for bootstrapping. Now, we can bootstrap directly from the sources of these packages in git. The `bootstrapped-pip` packages is used to build `pip`, `setuptools` and `wheel`, after which those packages are used to build everything else. Note that when building `bootstrapped-pip` some errors are shown. These are not important, the build actually does succeed and work as intended.
jonringer
reviewed
Oct 20, 2019
jonringer
approved these changes
Oct 20, 2019
There was a problem hiding this comment.
able to build pytest on all the platforms (skipped 38 because it's broken on master, might work on staging though...)
[10:31:59] jon@jon-desktop /home/jon/projects/nixpkgs ((9986d39a9f9...))
$ nix build -f . --keep-going pythonPackages.pytest python35Packages.pytest python36Packages.pytest python37Packages.pytest python38Packages.python
[100 built, 2 copied, 0.0 MiB DL]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since wheel support was introduced in 2015 we always relied on pre-built
wheels for bootstrapping. Now, we can bootstrap directly from the
sources of these packages in git.
The
bootstrapped-pippackages is used to buildpip, after whichthat
pipis used for everything else. Note that when buildingbootstrapped-pipsome errors are shown. These are not important,the build actually does succeed and work as intended.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @