Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arrayfire: do not use cudatoolkit at all on darwin #71454

Closed
wants to merge 1 commit into from
Closed

arrayfire: do not use cudatoolkit at all on darwin #71454

wants to merge 1 commit into from

Conversation

chessai
Copy link
Member

@chessai chessai commented Oct 20, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @chessai @dmjio

@chessai
Copy link
Member Author

chessai commented Oct 20, 2019

This PR is an extension to #71413. In order to build properly on MacOS, cudatoolkit needs to be left out of the picture.

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 21, 2019

@GrahamcOfBorg build arrayfire

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 21, 2019 •
edited

Couldn't you use opencl-clhpp, clblas from nixpkgs as build inputs ?
And clfft too now. :)

@chessai
Copy link
Member Author

chessai commented Oct 21, 2019 via email

@chessai
Copy link
Member Author

chessai commented Oct 28, 2019

Closing. See #72142 as a replacement

@chessai chessai closed this Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chessai @c0bw3b