Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kustomize: 3.1.0 -> 3.3.1 #71453

Merged
merged 1 commit into from Oct 20, 2019
Merged

kustomize: 3.1.0 -> 3.3.1 #71453

merged 1 commit into from Oct 20, 2019

Conversation

jonringer
Copy link
Contributor

Motivation for this change

closes #69621

@vdemeester I'm not sure how to get the version injected, they changed how their versioning works. If you have any ideas, I'm all ears; I tried for longer than I cared for :(. Also, I have no idea what I'm doing with golang :D.

If you're okay with --version spouting just unknown, I can clean up the commented out code, and finalize the PR.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jonringer jonringer changed the title kustomize: 3.1.0 -> 3.3.1 [Draft] kustomize: 3.1.0 -> 3.3.1 Oct 20, 2019
@jonringer
Copy link
Contributor Author

I'll wait for @vdemeester to respond, otherwise I'm fine with how it is now (even if it doesn't work for me)

@jonringer jonringer changed the title [Draft] kustomize: 3.1.0 -> 3.3.1 kustomize: 3.1.0 -> 3.3.1 Oct 20, 2019
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build kustomize

@jonringer
Copy link
Contributor Author

cc @kalbasit does this look good to you?

@jonringer
Copy link
Contributor Author

rebased off master, seems to have effected the modSha

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build kustomize

@turboMaCk
Copy link
Member

turboMaCk commented Oct 20, 2019 •
edited

I still have this problem on my machine though :/

hash mismatch in fixed-output derivation '/nix/store/v3nvgm6v60k789r9z3ca3yfq3lygf005-kustomize-3.3.1-go-modules':
  wanted: sha256:1jyfj5x09cx8l3hgxgl3v2lvvzwfzx87dxcmpp3r7nnhicyl5slb
  got:    sha256:0vhifkw8cv99729n3xi0xwn070bwaw6hfndzdhj9g0zd0yn6a1ah

But I don't understand how this new gomod stuff works at all.

@jonringer
Copy link
Contributor Author

I force pushed, "1jyfj5x09cx8l3hgxgl3v2lvvzwfzx87dxcmpp3r7nnhicyl5slb" has been removed completely in the last update

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg eval

@turboMaCk
Copy link
Member

  • builds on nixos
  • binary works on nixos
  • version option wors as expected

looks great to me.

@jonringer
Copy link
Contributor Author

not sure why ofborg isn't eval'ing, but

[1 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/71453
1 package were build:
kustomize

[nix-shell:/home/jon/.cache/nix-review/pr-71453]$ nix path-info -Sh ./results/kustomize
/nix/store/gkx8lr68d17ilg96mzql2mlan8a6k9h0-kustomize-3.3.1       58.3M

[nix-shell:/home/jon/.cache/nix-review/pr-71453]$ tree ./results/kustomize
./results/kustomize
└── bin
    └── kustomize

1 directory, 1 file

which matches:

[13:42:09] jon@jon-desktop /home/jon/projects/nixpkgs (master)
$ nix-build -A kustomize
these paths will be fetched (6.73 MiB download, 28.64 MiB unpacked):
  /nix/store/9wb349r8bkgs608j6b0r41dvzx7pbl6z-kustomize-3.1.0
copying path '/nix/store/9wb349r8bkgs608j6b0r41dvzx7pbl6z-kustomize-3.1.0' from 'https://cache.nixos.org'...
/nix/store/9wb349r8bkgs608j6b0r41dvzx7pbl6z-kustomize-3.1.0
[13:42:15] jon@jon-desktop /home/jon/projects/nixpkgs (master)
$ tree ./result
./result
└── bin
    └── kustomize

1 directory, 1 file

@jonringer jonringer merged commit 8298ecc into NixOS:master Oct 20, 2019
@jonringer jonringer deleted the bump-kustomize branch October 20, 2019 20:43
@jonringer
Copy link
Contributor Author

thanks @turboMaCk for all the help :)

@jonringer
Copy link
Contributor Author

also,

[nix-shell:/home/jon/.cache/nix-review/pr-71453]$ ./results/kustomize/bin/kustomize version
Version: {Version:3.3.1 GitCommit:f2ac5a2d0df13c047fb20cbc12ef1a3b41ce2dad BuildDate:unknown GoOs:linux GoArch:amd64}

@turboMaCk
Copy link
Member

my pleasure, really.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turboMaCk turboMaCk turboMaCk approved these changes

@vdemeester vdemeester Awaiting requested review from vdemeester

@zaninime zaninime Awaiting requested review from zaninime

@periklis periklis Awaiting requested review from periklis

@carlosdagos carlosdagos Awaiting requested review from carlosdagos

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @turboMaCk