Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macvim: snapshot-157 -> snapshot-161 #71380

Merged
merged 1 commit into from
Nov 7, 2019
Merged

macvim: snapshot-157 -> snapshot-161 #71380

merged 1 commit into from
Nov 7, 2019
+14 −44

Conversation

lilyball
Copy link
Member

@lilyball lilyball commented Oct 19, 2019 •
edited
Loading

Motivation for this change

https://github.com/macvim-dev/macvim/releases/tag/snapshot-159
https://github.com/macvim-dev/macvim/releases/tag/snapshot-160
https://github.com/macvim-dev/macvim/releases/tag/snapshot-161

Things done
  • Tested using sandboxing (using relaxed on macOS, as required by the use of a custom sandbox profile)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot added the 6.topic: vim label Oct 19, 2019
@ofborg ofborg bot requested a review from cstrahan October 19, 2019 07:33
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 19, 2019
@lilyball lilyball changed the title macvim: snapshot-157 -> snapshot-159 macvim: snapshot-157 -> snapshot-161 Oct 30, 2019
@lilyball
Copy link
Member Author

Updated to snapshot-161.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/73

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 7, 2019

@GrahamcOfBorg build macvim

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 7, 2019

@lilyball it's failing to build on ofBorg darwin builder and on Hydra with no clear errors.
Any idea why?

@lilyball
Copy link
Member Author

lilyball commented Nov 7, 2019

@c0bw3b the macvim package requires Xcode to be installed and won't build with the full sandboxed, only the relaxed one. Some day I hope to get it building without Xcode, but for the time being it won't build on ofBorg/Hydra.

@lilyball
Copy link
Member Author

lilyball commented Nov 7, 2019

I'm not sure why the build log doesn't say anything; I'm not sure why it even gets to the patching stage, I would have expected it to bail early due to the presence of sandboxProfile.

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 7, 2019

OK. Do you mind adding hydraPlatforms = []; in meta in the meantime?
It would save some Hydra resources for other pkgs.

@lilyball
Copy link
Member Author

lilyball commented Nov 7, 2019

@c0bw3b Done. I was unaware of that attribute or I would have used it sooner.

@ofborg ofborg bot added 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin and removed 10.rebuild-darwin: 1-10 labels Nov 7, 2019
@c0bw3b c0bw3b merged commit d5cb3fc into NixOS:master Nov 7, 2019
@lilyball lilyball deleted the macvim branch November 7, 2019 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cstrahan cstrahan

Assignees
No one assigned
Labels
6.topic: vim 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lilyball @nixos-discourse @c0bw3b