rustc: bump runtime LLVM to match upstream #71430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` rustc 1.38.0 binary: rustc commit-hash: unknown commit-date: unknown host: x86_64-unknown-linux-gnu release: 1.38.0 LLVM version: 9.0 ```
Mic92
reviewed
Oct 21, 2019
| @@ -1,6 +1,6 @@ | |||
| { stdenv, removeReferencesTo, pkgsBuildBuild, pkgsBuildHost, pkgsBuildTarget | |||
| , fetchurl, file, python2 | |||
| , llvm_7, darwin, git, cmake, rustPlatform | |||
| , llvm_9, darwin, git, cmake, rustPlatform | |||
There was a problem hiding this comment.
I think we can switch to llvmPackages_latest.llvm instead.
There was a problem hiding this comment.
Maybe it will be better to stick with version 9 and bump when rust upstream switches to newer version. I don't have strong opinion on this one.
There was a problem hiding this comment.
In that case please leave a note in rustc for maintainers to also check for the used llvm version when updating rustc.
|
@GrahamcOfBorg build rustc |
|
@GrahamcOfBorg build fd |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Bumps rustc llvm to version 9 to match upstream. Check: https://github.com/rust-lang/rust/blob/stable/.gitmodules#L43
Rustc supports multiple versions of LLVM and using nixpkgs default one (currently LLVM 7) works fine. I'm suggesting to follow upstream version as much as we can to eliminate potential bugs (leveraging fixes included in releases) also bringing latest LLVM optimizations.
I've did quick test with
fdpackage and internal rust project. Didn't found any problems.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @edolstra