Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.MojoliciousPluginOpenAPI: init at 2.17 #71377

Merged
merged 1 commit into from Oct 20, 2019
Merged

perlPackages.MojoliciousPluginOpenAPI: init at 2.17 #71377

merged 1 commit into from Oct 20, 2019

Conversation

stigtsp
Copy link
Member

@stigtsp stigtsp commented Oct 19, 2019

Adds the Mojolicious::Plugin::OpenAPI Perl module.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @volth

@stigtsp stigtsp force-pushed the package/perl-mojolicious-plugin-openapi-init branch from 19488e4 to c48d6a4 Compare October 19, 2019 15:22
@risicle
Copy link
Contributor

risicle commented Oct 20, 2019

Fails on macos (10.13):

building '/nix/store/h6jgxr0k1xa5p6hcrd7gj1mhkgvs0jlq-perl5.28.2-Net-IDN-Encode-2.500.drv'...
unpacking sources
unpacking source archive /nix/store/1j5xcpb25i1i7hc60gccimnfr72b5z3p-Net-IDN-Encode-2.500.tar.gz
source root is Net-IDN-Encode-2.500
setting SOURCE_DATE_EPOCH to timestamp 1538785687 of file Net-IDN-Encode-2.500/t/xtra_pp.t
patching sources
configuring
patching ./eg/hello_idn_email.pl...
patching ./eg/hello_idn.pl...
Checking if your kit is complete...
Looks good
Generating a Unix-style Makefile
Writing Makefile for Net::IDN::Encode
Writing MYMETA.yml and MYMETA.json
no configure script, doing nothing
building
ld: unknown option: -mmacosx-version-min=10.12
Warning: ExtUtils::CBuilder not installed or no compiler detected
Proceeding with configuration, but compilation may fail during Build

Created MYMETA.yml and MYMETA.json
Creating new 'Build' script for 'Net-IDN-Encode' version '2.500'
Building Net-IDN-Encode
Error: no compiler detected to compile 'lib/Net/IDN/Punycode.c'.  Aborting
builder for '/nix/store/h6jgxr0k1xa5p6hcrd7gj1mhkgvs0jlq-perl5.28.2-Net-IDN-Encode-2.500.drv' failed with exit code 255

@stigtsp
Copy link
Member Author

stigtsp commented Oct 20, 2019

@risicle Thx for testing on macOS.

Since ExtUtils::CBuilder is a part of core modules, it could be related to the ld: unknown option: -mmacosx-version-min=10.12 error message. I'll locate a Mac and try to fix the problem.

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 20, 2019

@stigtsp you just need to add perlPreHook = "export LD=$CC"; to NetIDNEncode

And it will fixed a recurring failure on Hydra as a bonus :)

@stigtsp stigtsp force-pushed the package/perl-mojolicious-plugin-openapi-init branch from c48d6a4 to a2275a6 Compare October 20, 2019 18:40
@stigtsp stigtsp force-pushed the package/perl-mojolicious-plugin-openapi-init branch from a2275a6 to f82d733 Compare October 20, 2019 18:42
@stigtsp
Copy link
Member Author

stigtsp commented Oct 20, 2019

@c0bw3b I've added perlPreHook = "export LD=$CC"; in this commit. Would you rather have it as a separate commit/pr?

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 20, 2019

It's ok as-is.

@GrahamcOfBorg build perl528Packages.MojoliciousPluginOpenAPI perl530Packages.MojoliciousPluginOpenAPI perl528Packages.NetIDNEncode perl530Packages.NetIDNEncode

@c0bw3b c0bw3b merged commit 89c0e5b into NixOS:master Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stigtsp @risicle @c0bw3b