Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tab: init at 7.2 #71466

Merged
merged 1 commit into from Oct 20, 2019
Merged

tab: init at 7.2 #71466

merged 1 commit into from Oct 20, 2019

Conversation

mstarzyk
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • [] Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@mstarzyk mstarzyk mentioned this pull request Oct 20, 2019
Closed
10 tasks
jonringer
jonringer approved these changes Oct 20, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
executable seems to work
leaf package

[3 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/71466
1 package were build:
tab

[nix-shell:/home/jon/.cache/nix-review/pr-71466]$ nix path-info -Sh ./results/tab
/nix/store/a57xzbc1487vqsyw8qcr266446ymhv1m-tab-7.2       33.4M

@jonringer jonringer merged commit 642bed5 into NixOS:master Oct 20, 2019
@mstarzyk mstarzyk deleted the tab-7.2 branch October 20, 2019 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mstarzyk @jonringer