Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[r19.09] rsyslog: add patch for CVE-2019-17040 #71370

Merged
merged 1 commit into from
Oct 19, 2019
Merged

[r19.09] rsyslog: add patch for CVE-2019-17040 #71370

merged 1 commit into from
Oct 19, 2019
+9 −2

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Oct 19, 2019 •
edited by c0bw3b
Loading

Motivation for this change

https://nvd.nist.gov/vuln/detail/CVE-2019-17040

For master, see #69954

I haven't finished running the nixos tests, but everything else seems fine so far.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

@risicle
rsyslog: add patch for CVE-2019-17040

Verified

This commit was signed with the committer’s verified signature. The key has expired.
thoughtpolice Austin Seipp
GPG key ID: 25D2038DEB08021D
Expired
Verified
Learn about vigilant mode
9cb599a
@risicle risicle changed the title rsyslog: add patch for CVE-2019-17040 [r19.09] rsyslog: add patch for CVE-2019-17040 Oct 19, 2019
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Oct 19, 2019
@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 19, 2019

@GrahamcOfBorg build nixosTests.rsyslogd

c0bw3b
c0bw3b approved these changes Oct 19, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nix-review pr 71370 1

2 package were build:
  • rsyslog
  • rsyslog-light

@c0bw3b c0bw3b merged commit 9ffddd8 into NixOS:release-19.09 Oct 19, 2019
@veprbl veprbl added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@risicle @c0bw3b @veprbl