Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lidarr: Add missing dependency chromaprint #71445

Merged
merged 2 commits into from Oct 23, 2019
Merged

lidarr: Add missing dependency chromaprint #71445

merged 2 commits into from Oct 23, 2019

Conversation

etu
Copy link
Contributor

@etu etu commented Oct 20, 2019 •
edited

Motivation for this change

Without adding this dependency in the system status page I get the
warning saying the following:

fpcalc could not be found. Audio fingerprinting disabled.

With this dep we instead get the following:

You have an old version of fpcalc. Please upgrade to 1.4.3.

Which I would find an improvement from the current state.

But that would be fixed in a separate pull request.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 20, 2019

chromaprint was just bumped to 1.4.3 in #70658

@etu
Copy link
Contributor Author

etu commented Oct 20, 2019

@GrahamcOfBorg test lidarr

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 22, 2019

I'm seeing this afterwards: makeWrapper should rather be in nativeBuildInputs

@etu etu force-pushed the lidarr-add-missing-dependency branch from d3cc05c to 0c5234a Compare October 22, 2019 15:38
@etu
lidarr: Add missing dependency chromaprint
d9975aa 
Without adding this dependency in the system status page I get the
warning saying the following:
> fpcalc could not be found. Audio fingerprinting disabled.

With this dep we instead get the following:
> You have an old version of fpcalc. Please upgrade to 1.4.3.

Which I would find an improvement from the current state.
@etu
sonarr: Move build time dependency
a18d59a
@etu etu force-pushed the lidarr-add-missing-dependency branch from 0c5234a to a18d59a Compare October 22, 2019 15:40
@ofborg ofborg bot requested a review from fadenb October 22, 2019 16:34
@c0bw3b c0bw3b merged commit cc06fe2 into NixOS:master Oct 23, 2019
@etu etu deleted the lidarr-add-missing-dependency branch October 23, 2019 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

@fadenb fadenb Awaiting requested review from fadenb

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@etu @c0bw3b