-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cdrtools: 3.02a06 -> 3.02a09 #71405
cdrtools: 3.02a06 -> 3.02a09 #71405
Conversation
I'm adding the WIP label only because ofBorg Darwin builder seems offline and I don't want to add any more jobs to its waiting queue. |
@GrahamcOfBorg build cdrtools dvdplusrwtools |
|
@GrahamcOfBorg build cdrtools dvdplusrwtools |
Thanks @risicle Locally on nixos: Result of 1 package are marked as broken and were skipped:
12 package were build:
And I can't reproduce ofborg failure when building |
One has to eval locally because ofBorg eval ignores packages with $ nix-review pr 71405 -p cdrtools --eval local
[...]
1 package were build:
cdrtools
[...]
$ ./results/cdrtools/bin/mkisofs --version
mkisofs 3.02a09 (x86_64-unknown-linux-gnu)
$ ./results/cdrtools/bin/cdrecord --version
Cdrecord-ProDVD-ProBD-Clone 3.02a09 (x86_64-unknown-linux-gnu) Copyright (C) 1995-2016 Joerg Schilling |
In a second nixos VM on another machine : $ nix-review pr 71405 --eval local
[...]
13 package were build:
bashburn bombono brasero cdrtools dvd-slideshow dvdplusrwtools dvdstyler k3b sound-juicer terraform-full terraform-provider-libvirt terraform_0_11-full terragrunt
$ ./results/cdrtools/bin/cdrecord --version
Cdrecord-ProDVD-ProBD-Clone 3.02a09 (x86_64-unknown-linux-gnu) Copyright (C) 1995-2016 Joerg Schilling |
+ replace local patches with Gentoo ones + add meta.licenses
@GrahamcOfBorg build cdrtools dvdplusrwtools |
Turns out the previous build failures of |
Motivation for this change
cdrtools
updatedvdplusrwtools
revamp in order to replace local patches with ones we can fetch, + set meta.licenseThings done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @