Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cdrtools: 3.02a06 -> 3.02a09 #71405

Merged
merged 2 commits into from Oct 23, 2019
Merged

cdrtools: 3.02a06 -> 3.02a09 #71405

merged 2 commits into from Oct 23, 2019

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Oct 19, 2019 •
edited

Motivation for this change
  • cdrtools update
  • dvdplusrwtools revamp in order to replace local patches with ones we can fetch, + set meta.license
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@c0bw3b
Copy link
Contributor Author

c0bw3b commented Oct 19, 2019

I'm adding the WIP label only because ofBorg Darwin builder seems offline and I don't want to add any more jobs to its waiting queue.

@c0bw3b
Copy link
Contributor Author

c0bw3b commented Oct 20, 2019

@GrahamcOfBorg build cdrtools dvdplusrwtools

@risicle
Copy link
Contributor

risicle commented Oct 20, 2019 •
edited

nix-review builds happily macos 10.13, all binaries appear to execute.

@c0bw3b
Copy link
Contributor Author

c0bw3b commented Oct 20, 2019

@GrahamcOfBorg build cdrtools dvdplusrwtools

@c0bw3b
Copy link
Contributor Author

c0bw3b commented Oct 20, 2019

Thanks @risicle

Locally on nixos:

Result of nix-review pr 71405 1

1 package are marked as broken and were skipped:
  • k9copy (kdeApplications.k3b)
12 package were build:
  • bashburn (kdeApplications.k3b)
  • bombono (kdeApplications.k3b)
  • brasero (kdeApplications.k3b)
  • dvd-slideshow (kdeApplications.k3b)
  • dvdplusrwtools (kdeApplications.k3b)
  • dvdstyler (kdeApplications.k3b)
  • k3b (kdeApplications.k3b)
  • sound-juicer (kdeApplications.k3b)
  • terraform-full (kdeApplications.k3b)
  • terraform-providers.libvirt (kdeApplications.k3b)
  • terraform_0_11-full (kdeApplications.k3b)
  • terragrunt (kdeApplications.k3b)

And I can't reproduce ofborg failure when building cdrtools 😕

@c0bw3b
Copy link
Contributor Author

c0bw3b commented Oct 20, 2019

One has to eval locally because ofBorg eval ignores packages with hydraPlatforms = []; so:

$ nix-review pr 71405 -p cdrtools --eval local
[...]
1 package were build:
cdrtools
[...]

$ ./results/cdrtools/bin/mkisofs --version
mkisofs 3.02a09 (x86_64-unknown-linux-gnu)

$ ./results/cdrtools/bin/cdrecord --version
Cdrecord-ProDVD-ProBD-Clone 3.02a09 (x86_64-unknown-linux-gnu) Copyright (C) 1995-2016 Joerg Schilling

@c0bw3b
Copy link
Contributor Author

c0bw3b commented Oct 21, 2019

In a second nixos VM on another machine :

$ nix-review pr 71405 --eval local
[...]
13 package were build:
bashburn bombono brasero cdrtools dvd-slideshow dvdplusrwtools dvdstyler k3b sound-juicer terraform-full terraform-provider-libvirt terraform_0_11-full terragrunt

$ ./results/cdrtools/bin/cdrecord --version
Cdrecord-ProDVD-ProBD-Clone 3.02a09 (x86_64-unknown-linux-gnu) Copyright (C) 1995-2016 Joerg Schilling

@c0bw3b c0bw3b changed the title cdrtools: 3.02a06 -> 3.02a09 [WIP] cdrtools: 3.02a06 -> 3.02a09 Oct 22, 2019
@c0bw3b c0bw3b self-assigned this Oct 22, 2019
@c0bw3b
cdrtools: 3.02a06 -> 3.02a09
382ca30
@c0bw3b
dvdplusrwtools: revamp at 7.1
845593d 
+ replace local patches with Gentoo ones
+ add meta.licenses
@c0bw3b
Copy link
Contributor Author

c0bw3b commented Oct 22, 2019

@GrahamcOfBorg build cdrtools dvdplusrwtools

@c0bw3b c0bw3b changed the title [WIP] cdrtools: 3.02a06 -> 3.02a09 cdrtools: 3.02a06 -> 3.02a09 Oct 23, 2019
@c0bw3b
Copy link
Contributor Author

c0bw3b commented Oct 23, 2019

Turns out the previous build failures of cdrtools were a consequence of parallel building.

@c0bw3b c0bw3b merged commit 748d444 into NixOS:master Oct 23, 2019
@c0bw3b c0bw3b deleted the pkg/cdrtools branch October 23, 2019 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@c0bw3b c0bw3b

Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@c0bw3b @risicle