Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

etcher: init at 1.5.60 #71404

Merged
merged 1 commit into from Dec 8, 2019
Merged

etcher: init at 1.5.60 #71404

merged 1 commit into from Dec 8, 2019

Conversation

Shou
Copy link
Contributor

@Shou Shou commented Oct 19, 2019

We add Etcher, the Electron image flasher.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Shou Shou mentioned this pull request Oct 19, 2019
Closed
@mmahut
Copy link
Member

mmahut commented Oct 20, 2019

Do you mind squashing your commits please?

@mmahut
Copy link
Member

mmahut commented Oct 20, 2019

@GrahamcOfBorg build etcher

@Shou
Copy link
Contributor Author

Shou commented Oct 21, 2019

@mmahut sure, I've squashed them now

@mmahut
Copy link
Member

mmahut commented Oct 23, 2019

@GrahamcOfBorg build etcher

@Shou
Copy link
Contributor Author

Shou commented Oct 28, 2019

I've removed some unused libraries (libnode.so and libffmpeg.so) that electron_3 already provides. They take a combined ~25MB so I think it's worth getting rid off.

@oneingan
Copy link
Contributor

oneingan commented Nov 8, 2019 •
edited

Getting this error in a xmonad desktop environment (no gnome) when I try to open image selection dialog:

(electron:14866): GLib-GIO-ERROR **: 15:25:23.928: No GSettings schemas are installed on the system
Trace/breakpoint trap (core dumped)

Related: #50985 #55057

@Myaats
Copy link
Member

Myaats commented Nov 24, 2019

Adding gtk3 and wrapGAppsHook as buildInputs should solve the file selection issue.

Also the desktop file should be changed to just exec balena-etcher-electron instead of /opt/balenaEtcher/balena-etcher-electron which does not exist.

@Shou
Copy link
Contributor Author

Shou commented Nov 24, 2019

@juaningan @DataMats thanks, I should've resolved this now

Br1ght0ne
Br1ght0ne reviewed Nov 24, 2019
View reviewed changes
Copy link
Member

@Br1ght0ne Br1ght0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, checked with nix-review on NixOS x86_64.

@Shou
etcher: init at 1.5.60
cd61ca1 
We add Etcher, the Electron image flasher.
@Shou
Copy link
Contributor Author

Shou commented Nov 24, 2019

Squashed commits

@mmahut
Copy link
Member

mmahut commented Nov 28, 2019

@GrahamcOfBorg build etcher

Lassulus
Lassulus approved these changes Dec 8, 2019
View reviewed changes
Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with nix-review

@Lassulus Lassulus merged commit 24b8c6d into NixOS:master Dec 8, 2019
@Shou Shou deleted the init-etcher branch December 8, 2019 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cleverca22 cleverca22 cleverca22 left review comments

@Lassulus Lassulus Lassulus approved these changes

@Myaats Myaats Myaats approved these changes

@Br1ght0ne Br1ght0ne Br1ght0ne approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Shou @mmahut @oneingan @Myaats @Lassulus @cleverca22 @Br1ght0ne