Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chit: 0.1.14 -> 0.1.15 #71403

Merged
merged 1 commit into from Oct 20, 2019
Merged

chit: 0.1.14 -> 0.1.15 #71403

merged 1 commit into from Oct 20, 2019

Conversation

lilyball
Copy link
Member

Motivation for this change

https://github.com/peterheesterman/chit/releases/tag/0.1.15

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle
Copy link
Contributor

risicle commented Oct 20, 2019

nix-review builds macos 10.13, binary executes.

c0bw3b
c0bw3b approved these changes Oct 20, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nix-review pr 71403 1

1 package were build:
  • chit
$ ./results/chit/bin/chit --version
chit 0.1.15

$ ./results/chit/bin/chit -c rustls
Searching for rustls...
─rustls──────────────────────────────────────
Rustls is a modern TLS library written in
Rust.

Rating: 🌟 🌟 🌟 🌟 🌟 
Total downloads: 813517
Recent downloads: 265558
Latest version: 0.16.0 (2019-08-10)
Docs: None specified in Cargo.toml
Repository: https://github.com/ctz/rustls
Crates.io: https://crates.io/crates/rustls
License: Apache-2.0/ISC/MIT
Crate size: 319 kB
Alternatives: None listed - Know one? Make a PR!
Keywords: 
Categories: cryptography, network-programming
Owner: ctz
─────────────────────────────────────────────

@c0bw3b c0bw3b merged commit 47ed10c into NixOS:master Oct 20, 2019
@lilyball lilyball deleted the chit branch October 20, 2019 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lilyball @risicle @c0bw3b