Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cutecom: 0.50.0 -> 0.51.0 #71385

Merged
merged 1 commit into from Oct 26, 2019
Merged

cutecom: 0.50.0 -> 0.51.0 #71385

merged 1 commit into from Oct 26, 2019

Conversation

oxzi
Copy link
Member

@oxzi oxzi commented Oct 19, 2019

Motivation for this change

This PR updates cutecom to its current release and changes its upstream repository which has moved to GitLab. Furthermore, its prefixing QT_PLUGIN_PATH as discussed in #56921 / 89cfbb9cb27317ef688e0d4e3d5681faaa53f87b.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @bennofs

@ofborg ofborg bot requested a review from bennofs October 19, 2019 13:55
@jonringer
Copy link
Contributor

there's also a wrapQtApp utility
@worldofpeace I keep forgetting which one is best practice

@ofborg ofborg bot requested a review from bennofs October 25, 2019 17:08
jonringer
jonringer approved these changes Oct 25, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
gui launches cleanly

[3 built, 2 copied (0.1 MiB), 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/71385
1 package were build:
cutecom

@worldofpeace worldofpeace merged commit 9231995 into NixOS:master Oct 26, 2019
@worldofpeace
Copy link
Contributor

backported in 4067ae8

@worldofpeace
Copy link
Contributor

Thanks for fixing this @geistesk 🌟

@oxzi oxzi deleted the cutecom-0.51.0 branch October 30, 2019 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@worldofpeace worldofpeace worldofpeace approved these changes

@bennofs bennofs Awaiting requested review from bennofs

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@oxzi @jonringer @worldofpeace @bennofs