docker-runc: switch to OCI runc 1.0.0-rc8+dev (security) #71386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The revision picked is based on https://github.com/docker/docker-ce/blob/19.03/components/engine/hack/dockerfile/install/runc.installer and https://github.com/docker/docker-ce/blob/18.09/components/engine/hack/dockerfile/install/runc.installer This should address CVE-2019-16884.
ofborg
bot
requested review from
tailhook,
vdemeester,
NeQuissimus,
offlinehacker and
periklis
NeQuissimus
approved these changes
Oct 19, 2019
|
@vdemeester @NeQuissimus: I don't have a commit bit, so somebody else will have to merge, if you think it's ready. |
NeQuissimus
added a commit
that referenced
this pull request
Oct 21, 2019
docker-runc: switch to OCI runc 1.0.0-rc8+dev (security) (cherry picked from commit 2dc7d61)
|
e6163fb for |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The revision picked is based on
https://github.com/docker/docker-ce/blob/19.03/components/engine/hack/dockerfile/install/runc.installer
and https://github.com/docker/docker-ce/blob/18.09/components/engine/hack/dockerfile/install/runc.installer
This should address CVE-2019-16884.
Related: #70464
Runc rev: opencontainers/runc@3e425f8
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @NeQuissimus @offlinehacker @tailhook @vdemeester @periklis