Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nfpm: 0.13.0 -> 1.0.0 #71417

Merged
merged 1 commit into from Oct 23, 2019
Merged

nfpm: 0.13.0 -> 1.0.0 #71417

merged 1 commit into from Oct 23, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Oct 20, 2019

Motivation for this change

Changelog: https://github.com/goreleaser/nfpm/releases/tag/v1.0.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from kalbasit October 20, 2019 02:50
@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 22, 2019

Builds and runs. Just a minor observation :

$ ./results/nfpm/bin/nfpm -v
master

@marsam
Copy link
Contributor Author

marsam commented Oct 23, 2019

@c0bw3b thanks for testing it, I've added a fix for the version string

c0bw3b
c0bw3b approved these changes Oct 23, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

$ ./results/nfpm/bin/nfpm -v
1.0.0

@marsam marsam merged commit 97bae4f into NixOS:master Oct 23, 2019
@marsam marsam deleted the update-nfpm branch October 23, 2019 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marsam @c0bw3b