Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

platformio: 4.0.3 -> 4.1.0 #76742

Closed
wants to merge 2 commits into from
Closed

platformio: 4.0.3 -> 4.1.0 #76742

wants to merge 2 commits into from

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Dec 31, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Mic92 Mic92 changed the title Platformio platformio: 4.0.3 -> 4.1.0 Dec 31, 2019
FRidh
FRidh requested changes Dec 31, 2019
View reviewed changes
Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be rebased onto staging-next

@Mic92 Mic92 changed the base branch from master to staging December 31, 2019 17:25
@ofborg ofborg bot requested review from globin and dotlambda December 31, 2019 18:10
@Mic92 Mic92 changed the base branch from staging to staging-next January 1, 2020 08:56
@Mic92
Copy link
Member Author

Mic92 commented Jan 1, 2020

Fixed

@boxofrox boxofrox mentioned this pull request Jan 2, 2020
Closed
10 tasks
@boxofrox
Copy link
Contributor

boxofrox commented Jan 2, 2020 •
edited

I rebased this PR onto nixpkgs-unstable (62ef779), and I run into a version conflict error with importlib-metadata

$ nix-env -f . -iA platformio
installing 'platformio'
these derivations will be built:
  /nix/store/1i2l5fjysj964c79d6cj5ijl7idis267-source.drv
  /nix/store/83zlg5mx6dm80d2hlx6zh1b3gihcdlaj-python3.7-tox-3.14.2.drv
  /nix/store/c7ngf2rim1wl5lszlyr7r14payzhxsdj-source.drv
  /nix/store/2p4wlsqp2gzz1nwkv0rbfrcc5k80081z-platformio-4.1.0.drv
  /nix/store/72gv5mcfxc07cm5ygav14z549486rlha-platformio-usr-target.drv
  /nix/store/g6js0kwc5m6bjw8f7hv8ypqxiwy2zzwg-python3.7-tox-3.14.2.drv
  /nix/store/b6m6z2kd0jl345ll40qwhza8zqikks6x-platformio-4.1.0.drv
  /nix/store/h7jmnxvmbw7agv4xlr0jh489jpw6ah3x-platformio-usr-multi.drv
  /nix/store/la4z7xawcz31d7hpm4pxxhvnjvfi5vcz-platformio-fhs.drv
  /nix/store/dqjnlvlwqsh0wyrp39r003wham4j18ar-platformio-init.drv
  /nix/store/kiscf14aingrhrc6s4lkbpnvyy0va2s9-platformio.drv
... trimmed output
Finished executing setuptoolsBuildPhase
installing
Executing pipInstallPhase
/build/tox-3.14.2/dist /build/tox-3.14.2
Processing ./tox-3.14.2-py2.py3-none-any.whl
ERROR: Could not find a version that satisfies the requirement importlib-metadata<2,>=1.1.0; python_version < "3.8" (from tox==3.14.2) (from versions: none)
ERROR: No matching distribution found for importlib-metadata<2,>=1.1.0; python_version < "3.8" (from tox==3.14.2)

I found on pypi [1], that importlib-metadata v1.3 is available, and nixpkgs remains on v0.23. I'm not sure what changed in nixpkgs-unstable to enable the requirement for importlib-metadata<2,>=1.1.0

I ran into this same error with PR #75913 after syncing nixpkgs-unstable to commit 62ef779. @Mic92 Do you run into this error also?

[1]: https://pypi.org/project/importlib-metadata/#history

Update: this error did not appear when my nixpkgs-unstable was at commit d942688. Attempting to bisect...

@boxofrox
Copy link
Contributor

boxofrox commented Jan 2, 2020 •
edited

Found it. python-tox v3.14.2 upgraded its dependency on importlib-metadata to v1.1.0 [1].

I'm new to nixpkgs development. Do we update the python{27,37}Packages.importlib-metadata from v0.23 to v1.1.0 to resolve the error? Appears to be resolved in staging-next by #76059.

[1]: tox-dev/tox@b4c4625

@makefu
Copy link
Contributor

makefu commented Jan 20, 2020

how does this pr fit to #78056 ?

@Mic92
Copy link
Member Author

Mic92 commented Jan 20, 2020

superseeded by #78056

@Mic92 Mic92 closed this Jan 20, 2020
@Mic92 Mic92 deleted the platformio branch July 23, 2021 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh requested changes

@jonringer jonringer Awaiting requested review from jonringer

@globin globin Awaiting requested review from globin

@dotlambda dotlambda Awaiting requested review from dotlambda

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Mic92 @boxofrox @makefu @FRidh