Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.unicorn: redesign to become a wrapper package around unicorn-emu #76762

Merged
merged 2 commits into from Jan 4, 2020
Merged

pythonPackages.unicorn: redesign to become a wrapper package around unicorn-emu #76762

merged 2 commits into from Jan 4, 2020

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Jan 1, 2020

Motivation for this change

Currently the python package is totally separate from the unicorn-emu package ending up performing almost the same compilation, while actually the "bindings" are really just a subdirectory of the main unicorn source. Re-using the compilation result will allow us to keep the two in sync and should allow more flexibility in creating overridden versions (which I'll have to do when I add unicorn support to the aflplusplus package in #76645).

At the same time I've fixed & enabled unicorn-emu on darwin.

Only reverse dependency rebuilds that fail seem already broken.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @bennofs @thoughtpolice

@ofborg ofborg bot requested review from thoughtpolice and bennofs January 1, 2020 02:12
@FRidh
Copy link
Member

FRidh commented Jan 1, 2020

@GrahamcOfBorg build pythonPackages.unicorn python3Packages.unicorn

@risicle
pythonPackages.unicorn: redesign to become a wrapper package around u…
d429ce7 
…nicorn-emu

this allows us to easily keep the two in sync and gives a more flexible
result, also add self as co-maintainer.
This was referenced Jan 1, 2020
Merged
Merged
thoughtpolice
thoughtpolice approved these changes Jan 4, 2020
View reviewed changes
Copy link
Member

@thoughtpolice thoughtpolice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thoughtpolice thoughtpolice merged commit 8b3e1e7 into NixOS:master Jan 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice thoughtpolice approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@bennofs bennofs Awaiting requested review from bennofs

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@risicle @FRidh @thoughtpolice