bandwhich: init at 0.6.0 #76689
Merged
bandwhich: init at 0.6.0 #76689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Br1ght0ne
added a commit
to Br1ght0ne/what
that referenced
this pull request
Dec 30, 2019
PR adding `what` to `nixpkgs`: NixOS/nixpkgs#76689
Br1ght0ne
force-pushed
the
what-0.5.1
branch
from
56b210d
to
bf17262
Compare
|
@GrahamcOfBorg eval |
|
Testing build on darwin |
There was a problem hiding this comment.
Build on Darwin fails due to missing Security; I've added suggestions below on how to add a dependency on it (let me know if you'd rather see a PR to your fork).
After applying these the build seems to finish successfully (although what itself seems to be broken under macOS right now: imsnif/bandwhich#31).
|
seems like it got renamed to https://github.com/imsnif/bandwhich |
- Rename from `what` to `bandwhich` - Add Security for darwin
Br1ght0ne
force-pushed
the
what-0.5.1
branch
from
b38dbe9
to
1a477dc
Compare
|
@cust0dian @teto Thanks, updated! |
timokau
reviewed
Dec 31, 2019
Closed
dtzWill
pushed a commit
to dtzWill/nixpkgs
that referenced
this pull request
Jan 6, 2020
bandwhich: init at 0.6.0 (cherry picked from commit a45447a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
https://github.com/imsnif/what/releases/tag/0.6.0
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)This change is