rx: 0.2.0 -> 0.3.0 #76703
Merged
rx: 0.2.0 -> 0.3.0 #76703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove "--features" invocations - Refactor some meta attributes
|
Damn, you were faster than me x) I tried running the tests under xvfb, but apparently even without the nix isolations, some tests fails for me :-/ (also apparently, meowhash supports only x86_64?) |
Ma27
approved these changes
Dec 30, 2019
AFAICS yes. Currently testing the package on a x86_64-darwin to ensure that this still works :) @GrahamcOfBorg build rx |
ofborg
bot
added
8.has: clean-up
10.rebuild-darwin: 0
and removed
10.rebuild-darwin: 1-10
labels
dtzWill
pushed a commit
to dtzWill/nixpkgs
that referenced
this pull request
Dec 31, 2019
rx: 0.2.0 -> 0.3.0 (cherry picked from commit ee562e5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
https://github.com/cloudhead/rx/releases/tag/v0.3.0
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @minijackson
This change is