Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

findomain: init at 0.9.3 #76693

Merged
merged 1 commit into from Jan 6, 2020
Merged

Conversation

Br1ght0ne
Copy link
Member

@Br1ght0ne Br1ght0ne commented Dec 30, 2019

Motivation for this change

https://github.com/Edu4rdSHL/findomain/releases/tag/0.9.3

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

@markuskowa
Copy link
Member

@GrahamcOfBorg build findomain

@markuskowa
Copy link
Member

Build fails on darwin.

@Br1ght0ne
Copy link
Member Author

@markuskowa This should fix it.

@Br1ght0ne
Copy link
Member Author

@GrahamcOfBorg build findomain

@markuskowa markuskowa merged commit c10e8d6 into NixOS:master Jan 6, 2020
@Br1ght0ne Br1ght0ne deleted the findomain-0.9.3 branch January 6, 2020 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants