Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schismtracker: 20120105 -> 20190805 #76725

Merged
merged 1 commit into from May 2, 2020
Merged

schismtracker: 20120105 -> 20190805 #76725

merged 1 commit into from May 2, 2020

Conversation

OPNA2608
Copy link
Contributor

@OPNA2608 OPNA2608 commented Dec 31, 2019 •
edited

Motivation for this change

Schismtracker was severely out of date. (not touched since it was added)

Things done

Updated version, switched to GitHub repository and dropped obsolete workaround.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    (72814208 -> 73078200)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @ftrvxmtrx

@OPNA2608 OPNA2608 mentioned this pull request Mar 5, 2020
Open
85 tasks
@ofborg ofborg bot requested a review from ftrvxmtrx April 14, 2020 20:18
@OPNA2608
Copy link
Contributor Author

Resolved merge conflict.

@veprbl veprbl merged commit d6fcf36 into NixOS:master May 2, 2020
@OPNA2608 OPNA2608 deleted the update-schismtracker branch September 27, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

@doronbehar doronbehar doronbehar approved these changes

@ftrvxmtrx ftrvxmtrx Awaiting requested review from ftrvxmtrx

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@OPNA2608 @veprbl @doronbehar