Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

steam.chroot: add at-spi2-core #76686

Merged
merged 1 commit into from Dec 30, 2019
Merged

steam.chroot: add at-spi2-core #76686

merged 1 commit into from Dec 30, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Dec 30, 2019 •
edited

Motivation for this change

Needed by CrossCode

closes #76685

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jonringer
steam.chroot: add at-spi2-core
28caa63 
Needed by CrossCode
@jonringer
Copy link
Contributor Author

it's already in the at-spi2-atk closure, so the closure size is still the same

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/steam-game-wants-libatspi-so-how-to-fix-this-properly/5208/4

@jonringer jonringer added 9.needs: port to stable A PR needs a backport to the stable release. 6.topic: steam labels Dec 30, 2019
@bjornfor bjornfor merged commit 21958c0 into NixOS:master Dec 30, 2019
@bjornfor
Copy link
Contributor

Backported to release-19.09: 5bbcc17

@jonringer jonringer deleted the steam-crosscode branch December 30, 2019 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
6.topic: steam 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Steam: "CrossCode" won't start
3 participants
@jonringer @nixos-discourse @bjornfor