Update interfaces/webrtc-identity.idl #20944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foolip
requested changes
Jan 3, 2020
There was a problem hiding this comment.
@stephenmcgruer can you find the spec change and report the duplication problem here? If a webrtc-pc update is in flight we might have to update both together here :/
| @@ -62,6 +66,29 @@ interface RTCIdentityAssertion { | |||
| attribute DOMString name; | |||
| }; | |||
|
|
|||
| partial interface RTCError { | |||
| readonly attribute long? httpRequestStatusCode; | |||
There was a problem hiding this comment.
The "Partial interface RTCError: member names are unique" subtest fails, and indeed this is already in https://w3c.github.io/webrtc-pc/#rtcerror-interface.
There was a problem hiding this comment.
Looks like w3c/webrtc-pc#2390 missed parts of httpRequestStatusCode in the move. I'll file a PR.
There was a problem hiding this comment.
That was w3c/webrtc-pc#2428. Thanks!
|
The RTCError duplication problem should be fixed now, PTAL @foolip |
foolip
approved these changes
Jan 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual version of #20662 with WebIDL dependency added