Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nextcloud module: https is important not only for proxies #76733

Merged
merged 1 commit into from Dec 31, 2019

Conversation

tokudan
Copy link
Contributor

@tokudan tokudan commented Dec 31, 2019

Motivation for this change

The old description suggests that the https variable can be off when nginx is directly configured with tls, which is not true and could lead to security issues.
I'm not sure if it's feasable to change the default value to reflect wether the nginx virtual host has tls enabled as that would introduce cross-module dependencies even if nextcloud is not even configured.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@tokudan
Copy link
Contributor Author

tokudan commented Dec 31, 2019

@GrahamcOfBorg test nextcloud.basic nextcloud.with-mysql-and-memcached nextcloud.with-postgresql-and-redis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants