Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stm32loader: 0.5.0 -> 0.5.1 #76747

Merged
merged 1 commit into from Jan 1, 2020
Merged

stm32loader: 0.5.0 -> 0.5.1 #76747

merged 1 commit into from Jan 1, 2020

Conversation

emilazy
Copy link
Member

@emilazy emilazy commented Dec 31, 2019

Motivation for this change

New upstream release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer approved these changes Dec 31, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
executables still seem to work

[5 built, 73 copied (44.5 MiB), 9.9 MiB DL]
https://github.com/NixOS/nixpkgs/pull/76747
3 package were built:
python27Packages.stm32loader stm32loader python38Packages.stm32loader

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python27Packages.stm32loader stm32loader python38Packages.stm32loader

@FRidh FRidh merged commit 31ef3b8 into NixOS:master Jan 1, 2020
@emilazy emilazy deleted the stm32loader-0.5.1 branch January 1, 2020 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@emilazy @jonringer @FRidh