nixosTests.hardened: port to python #76708
Conversation
|
@GrahamcOfBorg test hardened |
|
The test seems to fail. Is that expected? |
|
@joachifm I had the original Perl test fail too. Don't know for sure. |
|
@filalex77 the test seems to pass on Hydra. I'm curious what accounts for the difference, any idea? If you're reasonably sure this won't introduce a regression, I'm happy to defer to your judgement. The change LGTM (though I'm out-of-the loop wrt why tests are being ported to begin with). |
nixos/tests/hardened.nix
Outdated
|
|
||
| # Test hidepid | ||
| subtest "hidepid", sub { | ||
| $machine->succeed("grep -Fq hidepid=2 /proc/mounts"); | ||
| with subtest("hidepid"): |
There was a problem hiding this comment.
it would be cool if all subtest titles would be at least short sentences that describe your high-level expectation, instead of containing just one word.
|
Hey @filalex77, what's the state of this? |
|
@tfc Got a bit busy. Will fix it soon, thanks for reminding! |
|
Ping @filalex77. Btw, the testing driver was improved so you don't have to dig into the log for the exact failing subtest. |
Br1ght0ne
force-pushed
the
nixosTests.hardened-python
branch
from
1e92c54
to
36f98d5
Compare
|
Doesn't start on my machine (probably issue with KVM on my machine). |
|
Can this be rebased on current master? |
flokli
force-pushed
the
nixosTests.hardened-python
branch
from
36f98d5
to
462ce60
Compare
|
I rebased to latest master. For some reason, the "nix-daemon usage" subtest currently seems to fail. @filalex77, any idea? |
Motivation for this change
#72828
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @joachifm
This change is