pythonPackages.scipy: 1.3.3 -> 1.4.1 enable tests use github src #76755
Conversation
costrouc
force-pushed
the
python-scipy-tests
branch
4 times, most recently
from
568812f
to
76c8487
Compare
costrouc
force-pushed
the
python-scipy-tests
branch
from
76c8487
to
2deef15
Compare
| @@ -35,11 +52,9 @@ buildPythonPackage rec { | |||
| enableParallelBuilding = true; | |||
|
|
|||
| checkPhase = '' | |||
| runHook preCheck | |||
There was a problem hiding this comment.
This silently breaks preCheck and postCheck for users trying to use overrides.
There was a problem hiding this comment.
Yeah so question about this. Isn't this just the way it has always been done for ALL python packages (I never see people adding precheck and postcheck for python packages)? I looked at the git blame and those lines were written 6 years ago.
There was a problem hiding this comment.
I don't know the answer to your question. However, I did check that this breaks hooks even for python packages.
| @@ -55,7 +54,7 @@ buildPythonPackage rec { | |||
| checkInputs = [ | |||
| pytest | |||
| numpy | |||
| scipy | |||
| # scipy not included due to recursive dependency | |||
There was a problem hiding this comment.
Perhaps this could work:
| # scipy not included due to recursive dependency | |
| (scipy.override { pybind11 = null; }) |
| src = fetchPypi { | ||
| inherit pname version; | ||
| sha256 = "64bf4e8ae0db2d42b58477817f648d81e77f0b381d0ea4427385bba3f959380a"; | ||
| src = fetchFromGitHub { |
There was a problem hiding this comment.
This breaks eval for python2Packages.scipy:
nixpkgs/pkgs/top-level/python-packages.nix
Lines 5161 to 5164 in 286450b
|
This is already in staging-next |
Motivation for this change
This will be moved to staging-next. Wanted to make scipy tests enabled and use github src. This will enable testing scipy master easily against all dependant packages (something valuable to the python community). Sill a work in progress.
Since scipy 1.4.0 it requires pybind11 for the build. pybind11 uses scipy for tests. So scipy was removed from pybind11 dependencies
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @