Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.dask: 2.9.0 -> 2.9.1 enable tests, move to github src #76738

Merged
merged 4 commits into from Dec 31, 2019

Conversation

costrouc
Copy link
Member

@costrouc costrouc commented Dec 31, 2019

Motivation for this change

My goal is to ensure that all the core numeric python packages in nixpkgs have all tests enabled and use github as a src. The motivation for this is that in the long run this will enable us to have value to the python community in being able to easily check current master of a given package vs all dependent packages. Which upon talking with numpy/numba/scipy/matplotlib communities is something they really need. This may need to go into staging.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@FRidh
Copy link
Member

FRidh commented Dec 31, 2019

please rebase on staging-next

@FRidh FRidh changed the base branch from master to staging-next December 31, 2019 15:38
@costrouc
Copy link
Member Author

Ready for merge. Noticed that optuna was also broken which dependended on dask. Going to stop now adding more fixes in this PR

@FRidh FRidh merged commit 853ecd2 into NixOS:staging-next Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants